Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest merge of "wip-phpstan-level6" in TT-RSS breaks plugin feediron #175

Closed
meyca opened this issue Nov 18, 2021 · 0 comments · Fixed by #176
Closed

Latest merge of "wip-phpstan-level6" in TT-RSS breaks plugin feediron #175

meyca opened this issue Nov 18, 2021 · 0 comments · Fixed by #176

Comments

@meyca
Copy link

meyca commented Nov 18, 2021

Expected Behavior

Plugin works with latest version of TT-RSS

Current Behavior

After updating TT-RSS to latest commit including the "wip-phpstan-level6" branch I get a fatal error after login:

PHP Fatal error: Declaration of Feediron::csrf_ignore($method) must be compatible with IHandler::csrf_ignore(string $method): bool in /var/www/html/tt-rss/plugins.local/feediron/init.php on line 54

The updater throws the same error.

Steps to Reproduce

Update to latest TT-RSS.

Failure Information (for bugs)

PHP Fatal error: Declaration of Feediron::csrf_ignore($method) must be compatible with IHandler::csrf_ignore(string $method): bool in /var/www/html/tt-rss/plugins.local/feediron/init.php on line 54

Context

The branch referenced above includes various updates to the plugin interface.
s. https://community.tt-rss.org/t/heads-up-ongoing-attempt-to-comply-with-phpstan-rule-level-6/5046

  • Operating System:
  • static docker-compose install of TT-RSS
  • Feediron Configuration: n/a the plugin doesn't even load.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant