Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

managingEditor should be managing_editor #439

Closed
davidwparker opened this issue May 10, 2020 · 1 comment
Closed

managingEditor should be managing_editor #439

davidwparker opened this issue May 10, 2020 · 1 comment
Labels
good first issue Hacktoberfest

Comments

@davidwparker
Copy link

Per Ruby standards, it should be camel_case (not to mention the rest of the project).

It's weird to be managingEditor

feedjira/lib/feedjira/parser/itunes_rss.rb

Line 21 in b454324

element :managingEditor

@DominikAlberski DominikAlberski mentioned this issue Oct 9, 2020
Merged
@gkpacker
Copy link

@davidwparker Hey there! I think this issue can be closed, since #443 is merged

@HParker HParker closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidwparker @HParker @gkpacker