New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Travis CI, refactor gulp tasks #91
Conversation
@feimosi: bump |
I'll review and merge this, as well as #93, during the coming weekend. |
Cool, I wouldn't merge 93 personally, not close to a stable at least. |
@@ -97,12 +97,14 @@ gulp.task('update-version', function () { | |||
dist.js + '*.js' | |||
], { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you export this array of globs to a variable above the return? It'll be more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to do it later after we are done merging the PR.
* add a `lint` task * make JSHint fail if it has errors * add a test task
Done. |
LGTM 👍 |
Please do not squash these when merging. They are separate patches and should be like that when merged. |
Ok, just please, make sure to rebase the whole branch on top of master and I'll merge it. |
It is rebased already.
|
Ok, everything's fine 👍 |
See that is what I was saying all this time...
|
Take a look at my other comment: |
BTW I think we need margin for figure after all. I'll test it tomorrow and The regression is on mobile. Look at my other comment: — |
Also can you make the gh-pages branch and maybe create a dev one? I want to
|
|
I think everything is fine now. |
@feimosi: do not merge this yet, we need to decide which node.js version to run tests on.
In order to see this in action please add Travis CI to this repository.