Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis CI, refactor gulp tasks #91

Merged
merged 7 commits into from Apr 9, 2016
Merged

Add Travis CI, refactor gulp tasks #91

merged 7 commits into from Apr 9, 2016

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Apr 2, 2016

@feimosi: do not merge this yet, we need to decide which node.js version to run tests on.

In order to see this in action please add Travis CI to this repository.

@XhmikosR XhmikosR mentioned this pull request Apr 2, 2016
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 4, 2016

@feimosi: bump

@feimosi
Copy link
Owner

feimosi commented Apr 4, 2016

I'll review and merge this, as well as #93, during the coming weekend.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 4, 2016

Cool, I wouldn't merge 93 personally, not close to a stable at least.

@@ -97,12 +97,14 @@ gulp.task('update-version', function () {
dist.js + '*.js'
], {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you export this array of globs to a variable above the return? It'll be more readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to do it later after we are done merging the PR.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 9, 2016

Done.

@feimosi
Copy link
Owner

feimosi commented Apr 9, 2016

LGTM 👍

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 9, 2016

Please do not squash these when merging. They are separate patches and should be like that when merged.

@feimosi
Copy link
Owner

feimosi commented Apr 9, 2016

Ok, just please, make sure to rebase the whole branch on top of master and I'll merge it.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 9, 2016

It is rebased already.
On Apr 10, 2016 00:23, "Marek Grzybek" notifications@github.com wrote:

Ok, just please, make sure to rebase the whole branch on top of master and
I'll merge it.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#91 (comment)

@feimosi feimosi merged commit b3bee26 into feimosi:master Apr 9, 2016
@feimosi
Copy link
Owner

feimosi commented Apr 9, 2016

Ok, everything's fine 👍

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 9, 2016

See that is what I was saying all this time...
On Apr 10, 2016 00:40, "Marek Grzybek" notifications@github.com wrote:

Ok, everything's fine [image: 👍]


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#91 (comment)

@feimosi
Copy link
Owner

feimosi commented Apr 9, 2016

Take a look at my other comment:
2d50684

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 9, 2016

BTW I think we need margin for figure after all. I'll test it tomorrow and
make a pr until I manage to properly fix the styles.

The regression is on mobile.
On Apr 10, 2016 00:46, "Marek Grzybek" notifications@github.com wrote:

Look at my other comment:
2d50684
2d50684


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#91 (comment)

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 9, 2016

Also can you make the gh-pages branch and maybe create a dev one? I want to
start working on 2.x.
On Apr 10, 2016 01:10, xhmikosr@gmail.com wrote:

BTW I think we need margin for figure after all. I'll test it tomorrow and
make a pr until I manage to properly fix the styles.

The regression is on mobile.
On Apr 10, 2016 00:46, "Marek Grzybek" notifications@github.com wrote:

Look at my other comment:
2d50684
2d50684


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#91 (comment)

@XhmikosR XhmikosR mentioned this pull request Apr 10, 2016
@feimosi
Copy link
Owner

feimosi commented Apr 10, 2016

gh-pages is done, as well as dev branch. Could you test the current code base yourself, just to make sure and I'm gonna finally make the 1.6.0 release.
Unfortunately, my availability will be limited now.

@XhmikosR
Copy link
Contributor Author

I think everything is fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants