Add Dart linters to the packages

[tenhobi]

None of the packages uses lints in it's analysis_options.yaml file. (Except Angular which does have a few.)

My propose is to add more linters, so the code could easilly follow the same standards.

Maybe you know the package:pedantic Google internally uses as lints list. A few days ago I have made the package:effective_dart (https://github.com/tenhobi/effective_dart) which follows the Effecive Dart guide's lints, which I believe is suitable for our purpose.

Alternatively, we can make our own list, but the Effective Dart guide provides a good set of rule, I believe.

[felangel]

Hi @tenhobi 👋
Thanks for opening an issue!

I’ll definitely take a look at how effective_dart compares with pedantic and hopefully add one 👍. Thanks for bringing this up!

[tenhobi]

Btw. also check https://github.com/dart-lang/linter/tree/master/example and https://github.com/dart-lang/linter#usage for more info. (btw. as for now, effective dart repo is also mentioned there) 🙂

[felangel]

Awesome, I’ll try to take a look today 👍

[tenhobi]

Another reason why to use lints according the effective dart guide is that you can now add this super cool badge to your collection. 🤣

(just a joke ofc, consider what suits best for the project)

[felangel]

@tenhobi can you go over the differences between effective_dart and pedantic?

[tenhobi]

Basically, package:effective_dart attempts to comply with all Effective Dart guide rules which are described in that guide. package:pedantic sets only a limited subset of those rules (partial implementation) and maybe some other rules as well (which is not mentioned by the effective dart guide).

You can check the diff of https://github.com/tenhobi/effective_dart/blob/master/lib/analysis_options.1.0.0.yaml and https://github.com/dart-lang/pedantic/blob/master/lib/analysis_options.1.8.0.yaml.

The Effective Dart is the ideal state – the guide describes what you should do and don't do (and avoid, prefer, or concider) in your Dart project.

---

Or this is how I understand it. I like using the effective dart guide and I feel no real limitations.

[felangel]

@tenhobi thanks for the clarification 👍

I want to evaluate what the implications (if any) would be tomorrow (flying back from vacation 😛) and then can quickly make the updates if everything looks good. Thanks!

[tenhobi]

Sure, check both styles and evaluate. You can also easily see what lints are used using http://dart-lang.github.io/linter/lints/ page. Tho I will add support for showing effective_dart tomorrow (tenhobi/effective_dart#1).

Wow, flying from vacation and you did so much last days!

[felangel]

Wow, flying from vacation and you did so much last days!

Haha I tried to do what I can here and there on my phone 😛

[tenhobi]

Thx for your work!

[bernaferrari]

I missed this issue, only saw it today. I would like to say thanks to @felangel and all. I recently also added analysis_options to my app, and to my surprise there were maaaany issues. I got even more surprised since some of the issues were in my blocs, and most of them (at least their structure) were copied from the official samples. That meant samples weren't following the analyser.

But now they do. So no one will ever get again the warnings I got! Yaaay!

[tenhobi]

@bernaferrari it might not be an issue in general. Lints provides also (opinionated) styles how you write your code. And the official samples might follow a different set of rules, for some reason.

But it is a good idea to follow some set of rules for sure, to keep your project in one style.

Check https://github.com/tenhobi/effective_dart for Effective Dart rules. :-)