Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc bug: import path is wrong #77

Closed
realtebo opened this issue Jan 28, 2019 · 3 comments
Closed

Doc bug: import path is wrong #77

realtebo opened this issue Jan 28, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@realtebo
Copy link

Here: https://felangel.github.io/bloc/#/flutterinfinitelisttutorial?id=post-states

The import

import 'package:flutter_infinite_list/models/models.dart';

is wrong becausse at Data Model section we create post.dart and not models/models.dart.

If I am not wrong.

Sorry for annoying you with this issues.

@felangel
Copy link
Owner

It’s not wrong I just didn’t want to make the tutorial cumbersome and tell you how to structure you application. I was more focused on the content. If you look at the full source code (link at the end of the tutorial) you’ll see there is a models directory etc. I just didn’t think it’d be valuable to add in a bunch of text telling you to create directories.

If you think it’s confusing or think it’s valuable to be super specific about where files go let me know and I’ll update the tutorial.

@realtebo
Copy link
Author

Well, I copied your code. So I copied import too.
I encountered similar situation a few times again more later, but I fixed simply.

Update is not a need, but useful

@felangel felangel added this to In progress in bloc Jan 28, 2019
@felangel felangel self-assigned this Jan 28, 2019
@felangel felangel added the enhancement New feature or request label Jan 28, 2019
@felangel
Copy link
Owner

Okay I’ll make those updates. 👍

@felangel felangel moved this from In progress to Done in bloc Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
bloc
  
Done
Development

No branches or pull requests

2 participants