Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stringify = true by default #60

Closed
rtviwe opened this issue Feb 17, 2020 · 2 comments · Fixed by #69
Closed

Make stringify = true by default #60

rtviwe opened this issue Feb 17, 2020 · 2 comments · Fixed by #69
Assignees
@felangel
Labels
duplicate This issue or pull request already exists
Projects
equatable

Comments

@rtviwe
Copy link

rtviwe commented Feb 17, 2020

I have to always write:

@override
bool get stringify => true;

Mostly all classes which extends Equatable needs to override toString().
@rtviwe rtviwe changed the title Make stringify == true by default Make stringify = true by default Feb 17, 2020
@felangel felangel added the enhancement New feature or request label Feb 18, 2020
@felangel felangel added this to To do in equatable Feb 18, 2020
@zepfietje zepfietje mentioned this issue May 5, 2020
Closed
3 tasks
@felangel felangel self-assigned this May 27, 2020
@felangel
Copy link
Owner

Will try to work on a solution which aligns with #65 (comment).

@felangel felangel mentioned this issue May 29, 2020
Closed
@felangel
Copy link
Owner

felangel commented May 29, 2020 •
edited

Opened a proposal for this (#68). Closing this so we can consolidate all thoughts/feedback in #68.

@felangel felangel added duplicate This issue or pull request already exists and removed enhancement New feature or request labels May 29, 2020
@felangel felangel moved this from To do to Done in equatable May 29, 2020
@felangel felangel mentioned this issue May 29, 2020
Merged
3 tasks
@felangel felangel linked a pull request May 29, 2020 that will close this issue
feat: EquatableConfig for global stringify configuration #69
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felangel felangel

Labels
duplicate This issue or pull request already exists
Projects
equatable
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: EquatableConfig for global stringify configuration felangel/equatable
2 participants
@felangel @rtviwe