Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: FlowController notification behavior updates #61

Merged
merged 7 commits into from Nov 3, 2021

Conversation

felangel
Copy link
Owner

@felangel felangel commented Aug 6, 2021

Status

READY

Breaking Changes

YES

Description

  • refactor: FlowController notification behavior updates
  • refactor!: protected setter for FlowController state has been removed in favor of using controller.update.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Testing

@felangel felangel added the refactor Refactor an existing implementation label Aug 6, 2021
@felangel felangel self-assigned this Aug 6, 2021
@felangel felangel marked this pull request as ready for review August 6, 2021 16:47
ajgreenman
ajgreenman previously approved these changes Sep 2, 2021
definitelyokay
definitelyokay previously approved these changes Sep 2, 2021
erickzanardo
erickzanardo previously approved these changes Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor an existing implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants