Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameter names to OnGeneratePages #72

Merged
merged 1 commit into from Nov 3, 2021
Merged

feat: add parameter names to OnGeneratePages #72

merged 1 commit into from Nov 3, 2021

Conversation

Lootwig
Copy link
Contributor

@Lootwig Lootwig commented Nov 3, 2021

Status

READY

Breaking Changes

NO

Description

Convenience update to identify typedef function parameters when IDE supports auto-completion.
Before (IntelliJ): (p0, p1) => ...
After: (state, pages) => ...

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Testing

@felangel felangel added the enhancement New feature or request label Nov 3, 2021
@felangel felangel added this to In progress in flow_builder via automation Nov 3, 2021
@felangel felangel changed the title Add parameter names to OnGeneratePages typedef feat: add parameter names to OnGeneratePages Nov 3, 2021
@felangel felangel merged commit 5267a03 into felangel:master Nov 3, 2021
flow_builder automation moved this from In progress to Done Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants