Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockNetworkImages should provide a way to test the errorBuilder from Image.network #212

Open
DanielFerrariR opened this issue Oct 5, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@DanielFerrariR
Copy link

DanielFerrariR commented Oct 5, 2023

Details:
Sometimes, we need to provide an errorBuilder for Image.network, and, at least so far, I didn't see a way to test it without mocking httpClient, which is basically what mockNetworkImages already does.

Expected:
mockNetworkImages should have a new option to make the request fail as failed to fetch the image, so Image.Network can use the errorBuilder instead.

I would really appreciate it if someone had a better and simpler way to do it.

@DanielFerrariR DanielFerrariR changed the title Mock Image Network should provide a way to test the errorBuilder from Image.network mockImageNetwork should provide a way to test the errorBuilder from Image.network Oct 5, 2023
@DanielFerrariR DanielFerrariR changed the title mockImageNetwork should provide a way to test the errorBuilder from Image.network mockNetworkImages should provide a way to test the errorBuilder from Image.network Oct 5, 2023
@felangel felangel added the enhancement New feature or request label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants