Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace list with combo-box or picklist #997

Closed
mohsinbeg opened this issue Nov 9, 2023 · 6 comments · Fixed by #1003
Closed

Replace list with combo-box or picklist #997

mohsinbeg opened this issue Nov 9, 2023 · 6 comments · Fixed by #1003
Assignees
@Karakatiza666
Labels
User-facing For PRs that lead to Feldera-user visible changes Web Console Related to the browser based UI

Comments

@mohsinbeg
Copy link
Contributor

This list will become long and not usable if there are many tables and views. Also the label says Relation. A table or view is better labelled as an Entity.

image
@mohsinbeg mohsinbeg added Web Console Related to the browser based UI User-facing For PRs that lead to Feldera-user visible changes labels Nov 9, 2023
@Karakatiza666
Copy link
Collaborator

Karakatiza666 commented Nov 9, 2023 •
edited

Is this something you had in mind?
image
image

@Karakatiza666 Karakatiza666 self-assigned this Nov 9, 2023
@Karakatiza666 Karakatiza666 mentioned this issue Nov 9, 2023
Merged
@lalithsuresh
Copy link
Collaborator

I prefer Relation over Entity.

@ryzhyk thoughts?

@mohsinbeg
Copy link
Contributor Author

I prefer Relation over Entity.

@ryzhyk thoughts?

User creates tables and views in the SQL programs and that is familiar. Relations are typically Foreign Key constraints.

@ryzhyk
Copy link
Contributor

ryzhyk commented Nov 9, 2023

I think Entity is a modeling concept. Tables and Views are Relations. But maybe we can just call it "Tables and Views"?

@Karakatiza666
Copy link
Collaborator

image

@Karakatiza666
Copy link
Collaborator

Is there anything else to be improved in the scope of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karakatiza666 Karakatiza666

Labels
User-facing For PRs that lead to Feldera-user visible changes Web Console Related to the browser based UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor list of tables and views in breadcrumbs to autocomplete combobox feldera/feldera
4 participants
@lalithsuresh @ryzhyk @Karakatiza666 @mohsinbeg