Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nice looking 404 and 500 pages #65

Closed
Felienne opened this issue Apr 22, 2020 · 8 comments · Fixed by #992
Closed

Create nice looking 404 and 500 pages #65

Felienne opened this issue Apr 22, 2020 · 8 comments · Fixed by #992
Assignees

Comments

@Felienne
Copy link
Member

Felienne commented Apr 22, 2020

For example: http://www.hedycode.com/hedy/23?lang=nl

@Felienne Felienne reopened this Oct 13, 2020
@Felienne
Copy link
Member Author

Ah turns out I forgot the links changed, haha. So also the issue of the links still needs to be resolved.

@fpereiro
Copy link
Contributor

Hi @Felienne ! Reviewing the issue, I don't understand what's the issue regarding the links that should be fixed. Perhaps I can help with this, since it seems to be quite web related :).

@Felienne
Copy link
Member Author

@fpereiro As you can see I am cleaning stuff up haha!

This issue is still open:

image

Can we make this into a nice 404, or even better a redirect to something we do have?

@hedyorg hedyorg deleted a comment from moorlag Sep 15, 2021
@hedyorg hedyorg deleted a comment from moorlag Sep 15, 2021
@fpereiro
Copy link
Contributor

Hi @Felienne ! I think we could add a 404 page to catch misdirected requests. In this particular case, we could also redirect them to the first level of Hedy if they select a level that doesn't exist.

@fpereiro fpereiro self-assigned this Sep 15, 2021
@Felienne
Copy link
Member Author

Yes, let's do two things:

  • Redirect for his issue
  • Making a 404 page for other unfound pages

What do you think? Split this issue in two or do both for this issue?

@fpereiro
Copy link
Contributor

The redirect is so simple, that I'd do it all on this issue.

Could we have perhaps a Felienne Original for the 404? :D

@Felienne
Copy link
Member Author

Felienne commented Sep 23, 2021

Tadaaa! For the 404:

IMG_3834B719AAC3-1

@Felienne
Copy link
Member Author

And a 500 drawing to
IMG_E36B2043025B-1
o!

@fpereiro fpereiro changed the title Accessing a level that is not available gives an ugly error Create nice looking 404 and 500 pages Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants