Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_command 设置 block=True #63

Merged
merged 1 commit into from
May 21, 2022
Merged

on_command 设置 block=True #63

merged 1 commit into from
May 21, 2022

Conversation

MeetWq
Copy link
Contributor

@MeetWq MeetWq commented May 18, 2022

No description provided.

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nonebot-bison ✅ Ready (Inspect) Visit Preview May 18, 2022 at 8:36AM (UTC)

@felinae98
Copy link
Collaborator

所以这个之前有什么问题呢

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #63 (d22f97f) into main (d3af581) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   76.29%   76.29%           
=======================================
  Files          22       22           
  Lines        1582     1582           
=======================================
  Hits         1207     1207           
  Misses        375      375           
Impacted Files Coverage Δ
src/plugins/nonebot_bison/config_manager.py 95.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3af581...d22f97f. Read the comment docs.

@MeetWq
Copy link
Contributor Author

MeetWq commented May 18, 2022

所以这个之前有什么问题呢

因为 on_command 默认是 block=False , 这样别的插件会接着处理命令,可能会触发别的插件的命令
比如这样
Snipaste_2022-05-18_16-44-40.png

@felinae98
Copy link
Collaborator

所以这是和哪个插件产生了冲突

@felinae98 felinae98 changed the base branch from main to dev May 21, 2022 06:25
@felinae98 felinae98 merged commit 392be6b into MountainDash:dev May 21, 2022
@felinae98 felinae98 linked an issue May 22, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

可能会出现操控命令与其他插件冲突的问题
2 participants