Skip to content
This repository has been archived by the owner on Nov 10, 2021. It is now read-only.

README: 2 links to scripts/deploy.sh are dead #4

Closed
knbknb opened this issue Jan 23, 2020 · 1 comment
Closed

README: 2 links to scripts/deploy.sh are dead #4

knbknb opened this issue Jan 23, 2020 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@knbknb
Copy link

knbknb commented Jan 23, 2020

Your Vagrant Image might be a good starting point for my project, so I might check it out from Vagrantcloud. Besides, your shellscripts contain a nice bag of tricks. Thanks!

However, the README at this time contains 2 links to a nonexistant scripts/deploy.sh file. Please update or remove the links. I think it's now ci/deploy.sh.

And the base image is not hashicorp/bionic64, it's bento/ubuntu-18.04/

It would also helpful if you mentioned in the README how large the image actually is (approximately, in Gigabytes).

felipecrs added a commit that referenced this issue Jan 23, 2020
Using shields.io to provide the badge, and this simple and in very early stage endpoint I created to fetch the size: https://runkit.com/felipecassiors/vagrant-box-size

Issue: #4
felipecrs added a commit that referenced this issue Jan 23, 2020
@felipecrs
Copy link
Owner

felipecrs commented Jan 23, 2020

Hi!

Thank you for your feedback, it helps a lot! Also take a look on my-ubuntu1804-4dev, there you can find some tricks aimed for refined user/computer/environment settings.

I fixed the links in README, it was indeed ci/deploy.sh. Also the base box reference.

For the box size, I created a very simple (and in very early stage: currently you can't select which provider to get the size, not a problem for this box today since it only have virtualbox) badge to it, since there wasn't one already. I plan to enhance it over time, so other people may also use it.

Vagrant box size
Source code: https://runkit.com/felipecassiors/vagrant-box-size

@knbknb knbknb closed this as completed Jan 23, 2020
@felipecrs felipecrs self-assigned this Jan 31, 2020
@felipecrs felipecrs added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants