feat: add support for a different packageRoot #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrs
requested changes
Mar 2, 2024
Adapt so the extension can be in a non-root folder
felipecrs
approved these changes
Mar 2, 2024
|
Thanks a lot for your contribution! |
|
馃帀 This PR is included in version 5.7.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Hello
Thanks for putting this together 馃コ It's worked swimmingly for me so far. I refactored my repo recently so the VS Code extension is no longer on the root-level of the repo, without checking whether all the tools would support that. Turns out this one didn't.
This PR adapts the internals so the extension can be in a non-root folder. Both of these scenarios should be covered. In my case it was the 2nd scenario that caused problems.
cwdis root but extension is notcwdis not root, extension is incwdTested OK in https://github.com/wkillerud/some-sass using
patch-packageFixes #32