Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Export): add push to registry. Do some cleanup. #39

Merged
merged 2 commits into from Aug 12, 2022

Conversation

lucbpz
Copy link
Contributor

@lucbpz lucbpz commented Aug 12, 2022

What does this PR do?

  • Updates the Export dialog to include the push to registry option.
  • Cleanup actions - remove unused.
Updated dialog Cleanup actions
image image

@github-actions
Copy link

github-actions bot commented Aug 12, 2022

Docker image tag(s) pushed:

felipecruz/vackup-docker-extension:pr-39

Labels added to images:

org.opencontainers.image.title=vackup-docker-extension
org.opencontainers.image.description=Docker Extension to backup and restore docker volumes.
org.opencontainers.image.url=https://github.com/docker/vackup-docker-extension
org.opencontainers.image.source=https://github.com/docker/vackup-docker-extension
org.opencontainers.image.version=pr-39
org.opencontainers.image.created=2022-08-12T11:02:40.581Z
org.opencontainers.image.revision=81d7878a923fe992007bb3516e256a5530e2b955
org.opencontainers.image.licenses=MIT

Copy link
Collaborator

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same icon (arrow down) is being used for opposite actions

image

Copy link
Collaborator

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the description of every radio button option always displayed even if the option is not checked? And make them appear in bold 😄

image

@lucbpz
Copy link
Contributor Author

lucbpz commented Aug 12, 2022

@felipecruz91 Changed also some styles in other dialogs, and to be consistent now that our designs are consistent I changed both Import and Export dialog to display the description of each radio button always.

export dialog import dialog clone dialog delete dialog
image image image image

Copy link
Collaborator

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@felipecruz91 felipecruz91 merged commit 5f0115a into main Aug 12, 2022
@felipecruz91 felipecruz91 deleted the feature/export-push-to-registry branch August 12, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants