Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version number from file names to simplify version update #23

Closed
victor-homyakov opened this issue Oct 9, 2014 · 5 comments
Closed

Comments

@victor-homyakov
Copy link
Contributor

Currently, update of jsx-requirejs-plugin requires changes in RequireJS configuration, i.e. you should find in your project all occurrences of

paths: {
    //...
    "JSXTransformer": "JSXTransformer-0.X"
}

and replace them with

paths: {
    //...
    "JSXTransformer": "JSXTransformer-0.Y"
}

This could be troublesome in some cases, e.g. when you have multiple configurations, or configuration script is stored somewhere on server side (e.g. in JSP page or in C# control).

Update process could be easier when file name doesn't include version number.

@felipecrv
Copy link
Owner

I agree. Do you want to send a PR fixing this?

@victor-homyakov
Copy link
Contributor Author

I'd prefer to make this PR only when #24 will be closed (merged), because they both have conflicting changes.

@felipecrv
Copy link
Owner

I'd prefer to make this PR only when #24 will be closed (merged), because they both have conflicting changes.

Good call. Just merged #24.

@victor-homyakov
Copy link
Contributor Author

PR #25

@felipecrv
Copy link
Owner

Closed by #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants