Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to EzXML.jl #7

Closed
felipenoris opened this issue Apr 20, 2018 · 2 comments
Closed

Migrate to EzXML.jl #7

felipenoris opened this issue Apr 20, 2018 · 2 comments
Assignees
@felipenoris
Labels
performance

Comments

@felipenoris
Copy link
Owner

I suspect that this line of code from read function is killing performance:

xf.data[f.name] = LightXML.parse_string(readstring(f))

The problem is that LightXML.jl doesn´t allow for reading from IO streams, AFAIK.
Changing to EzXML.jl will also allow for implementing #3.
@felipenoris felipenoris self-assigned this Apr 20, 2018
@felipenoris
Copy link
Owner Author

Stuck on fhs/ZipFile.jl#39

@felipenoris felipenoris mentioned this issue May 1, 2018
Merged
@felipenoris
Copy link
Owner Author

It turns out the performance gains are minimal with this change...

@Deduction42 Deduction42 mentioned this issue Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipenoris felipenoris

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felipenoris