Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection not persistent in AsyncPersistentSender #161

Closed
felix-hilden opened this issue Mar 5, 2020 · 0 comments
Closed

Connection not persistent in AsyncPersistentSender #161

felix-hilden opened this issue Mar 5, 2020 · 0 comments
Assignees
@felix-hilden
Labels
bug Something isn't working

Comments

@felix-hilden
Copy link
Owner

When using an httpx.AsyncClient as a context, the connection is closed on exit, as noted in documentation. We should not use a context in AsyncPersistentSender, but request directly, like in AsyncSingletonSender.
@felix-hilden felix-hilden added the bug Something isn't working label Mar 5, 2020
@felix-hilden felix-hilden self-assigned this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felix-hilden felix-hilden

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felix-hilden