Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converting using from_url does not allow for https:// urls #165

Closed
aaronhnsy opened this issue Mar 31, 2020 · 4 comments
Closed

converting using from_url does not allow for https:// urls #165

aaronhnsy opened this issue Mar 31, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@aaronhnsy
Copy link

As the title says, when using tekore.convert.from_url it does not allow for http urls which are what the spotify client and web player both give when copying songs urls. Is there a reason for this?

@felix-hilden
Copy link
Owner

Thanks for posting! If this is indeed the case, then no reason. I'll see if the return urls should change too. But the API docs at https://developer.spotify.com/documentation/web-api/ still mention http urls only. So let's also figure out if both are used and where.

@felix-hilden felix-hilden added the bug Something isn't working label Mar 31, 2020
@aaronhnsy
Copy link
Author

As above, spotify gives me a https url when using the copy url feature of both the web player and the desktop app, these urls work just fine and even the normal http urls redirect to a https one.

@felix-hilden
Copy link
Owner

I do believe you, but I'll verify things myself too. Good to know about the redirects.

@felix-hilden
Copy link
Owner

Yeah, let's add the https style prefix to the list of accepted ones. Also, we'll return https URLs in to_url as well, since they seem to be used quite exclusively by Spotify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants