Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptive errors in auth with lacking configuration #210

Closed
felix-hilden opened this issue Sep 2, 2020 · 1 comment
Closed

Descriptive errors in auth with lacking configuration #210

felix-hilden opened this issue Sep 2, 2020 · 1 comment
Labels
change Change behaviour of an existing component
Milestone

Comments

@felix-hilden
Copy link
Owner

If a credentials client is misconfigured and authorisation is attempted, error messages emitted from the client itself are not clear. We shoud check the configuration before attempting to authorise to provide better information.

@felix-hilden felix-hilden added the change Change behaviour of an existing component label Sep 2, 2020
@felix-hilden felix-hilden added this to the v3.0.0 milestone Sep 2, 2020
@felix-hilden
Copy link
Owner Author

This is only currently true for adding auth headers without client secrets. I think we'll get away with simply raising a value error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Change behaviour of an existing component
Projects
None yet
Development

No branches or pull requests

1 participant