Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track market assertion fails #217

Closed
felix-hilden opened this issue Oct 5, 2020 · 5 comments
Closed

Track market assertion fails #217

felix-hilden opened this issue Oct 5, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@felix-hilden
Copy link
Owner

Currently tests fail because track markets are sometimes returned as an empty list instead of being missing. I've created an issue in the Spotify forum. This might or might not require action from our part, but code can maybe be left as it is, provided the test and documentation is changed.

@felix-hilden felix-hilden added bug Something isn't working waiting Waiting for another event labels Oct 5, 2020
@felix-hilden
Copy link
Owner Author

It's been a week now with no response, I think we ought to just change the test and mention the behavior in documentation.

@felix-hilden felix-hilden self-assigned this Oct 12, 2020
@felix-hilden
Copy link
Owner Author

felix-hilden commented Oct 12, 2020

On a second thought, we could actually just patch the behavior, such that empty market lists are converted to None values. At least until Spotify responds. I'll mark this issue for tracking as well. Our test coverage will take a hit, but so be it.

@felix-hilden felix-hilden added track Track something even after closing and removed waiting Waiting for another event labels Oct 12, 2020
@felix-hilden
Copy link
Owner Author

It also seems that there's some issue with search paging currently, so I'll wait that out before issuing this fix.

@felix-hilden
Copy link
Owner Author

It seems that my expectation that it would be a short-lived issue was not correct. Here's an issue to follow on the dev forums. For now, we'll ignore red test results.

@felix-hilden
Copy link
Owner Author

felix-hilden commented Oct 19, 2020

The search issue was fixed. I think we should just leave the behavior as it is in the API, as it has become consistent. We'll change the documentation to match new tests and address this again if something changes.

@felix-hilden felix-hilden removed the track Track something even after closing label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant