Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming and app-remote-control scopes #237

Conversation

oroddlokken
Copy link
Contributor

Adds tekore.scope.streaming and tekore.scope.app_remote_control attributes.

I didn't include them in tekore.scope.write, since I'm unsure if Spotify will let you complete the authorization process if you use an account without Premium.

  • Tests written with 100% coverage
  • Documentation and changelog entry written
  • All tox checks passed with an appropriately configured
    environment

@felix-hilden
Copy link
Owner

Thanks a bunch for the PR and nicely done! I added some documentation mentioning that they are indeed scopes for functionality outside the Web API and because of that also put them in one scope group at the very bottom of the list.

Authorised tests obviously fail because this is a PR from a fork, so no need to worry about that, I'll merge it right away and make a release in the near future!

@felix-hilden felix-hilden merged commit 0456bbf into felix-hilden:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants