Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename -account parameter to -target-account #13

Closed
ghost opened this issue Oct 16, 2018 · 3 comments
Closed

Rename -account parameter to -target-account #13

ghost opened this issue Oct 16, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 16, 2018

Please rename -account parameter to -target-account in order to prevent confusion on parameter purpose.
@felixb
Copy link
Owner

felixb commented Oct 17, 2018

This change would break all the running swamp instances in the wild.
I understand your point though.

@felixb felixb closed this as completed Oct 17, 2018
@ghost
Copy link
Author

ghost commented Oct 17, 2018

you could add -target-account still support -account and print a deprecation warning

@ghost
Copy link
Author

ghost commented Oct 17, 2018

or release a swamp2.
actually that sounds quite nice swamp to :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felixb