Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Highlight.js v10 #100

Closed
joshgoebel opened this issue Nov 19, 2020 · 6 comments
Closed

Upgrade to Highlight.js v10 #100

joshgoebel opened this issue Nov 19, 2020 · 6 comments

Comments

@joshgoebel
Copy link

Highlight.js v9 is very, very old and v10 contains 100s of fixes and improvements. We also just officially entirely dropped support for v9 and it should now be treated as a potential security risk for anyone still using it. Your simple uses case makes me think it'd be pretty easy for you to upgrade if you decided to do so.

@jamezrin
Copy link

I wouldn't hold my breath, this package has not been updated for more than a year.

@joshgoebel
Copy link
Author

joshgoebel commented Nov 19, 2020

Yeah, I was just dropping the note here since this was mentioned by some of the people trying to sort out their secondary dependencies. Sad though (if this is still generally useful - I dunno) because it looks like an easy fix but I don't have time to patch and maintain every single library downstream of us. :-) But I can ask - for those brought to my attention.

@joshgoebel
Copy link
Author

If you (or anyone) might want to help I wrote a TINY guide:

highlightjs/highlight.js#2882

@jamezrin
Copy link

It looks like @felixfbecker is still active in this repo, look at this: #99 (review)

@felixfbecker
Copy link
Owner

Fixed by #89.

@felixfbecker
Copy link
Owner

And @jamezrin, please spread negativity elsewhere. A package doesn't need updates if it works fine. Stability is a feature, not a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants