Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use git show instead of git log #118

Merged
merged 1 commit into from
Oct 20, 2018
Merged

fix: use git show instead of git log #118

merged 1 commit into from
Oct 20, 2018

Conversation

eseliger
Copy link
Collaborator

git log showed all commits to the given commit and hence was running out of memory

git log showed all commits to the given commit and hence was running out of memory
@eseliger eseliger added the bug label Oct 20, 2018
@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #118 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   99.78%   99.78%   +<.01%     
==========================================
  Files           5        5              
  Lines         460      462       +2     
  Branches       79       81       +2     
==========================================
+ Hits          459      461       +2     
  Misses          1        1
Impacted Files Coverage Δ
src/adapters/postgres.ts 100% <ø> (ø) ⬆️
src/git.ts 100% <100%> (ø) ⬆️
src/adapter.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fecf4...de162d6. Read the comment docs.

@eseliger eseliger merged commit b8121af into master Oct 20, 2018
@eseliger eseliger deleted the fix-memory-issue branch October 20, 2018 23:16
@@ -30,9 +30,9 @@ export interface TableRow {
id: number
name: string
type: TaskType
commit: string
commit: string | null
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says null but below it assigns undefined?

@felixfbecker
Copy link
Owner

🎉 This PR is included in version 0.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants