Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore folders for libraries #146

Closed
felixfbecker opened this issue Nov 14, 2016 · 10 comments
Closed

Ignore folders for libraries #146

felixfbecker opened this issue Nov 14, 2016 · 10 comments

Comments

@felixfbecker
Copy link
Owner

From @jaimerod on November 3, 2016 6:25

Add the ability to ignore folders that contain libraries. That way I don't get hundreds of warnings from somebody elses code.

Copied from original issue: felixfbecker/vscode-php-intellisense#26

@felixfbecker
Copy link
Owner Author

Ignore from indexing, or ignore from errors/warnings?

@felixfbecker
Copy link
Owner Author

From @jaimerod on November 3, 2016 7:55

Ignore the errors/warnings because it is code we should not be changing. Is there a way of muting those warnings? It is a good idea to index them because those libraries are still going to be used in the application and intellisense should still work.

@felixfbecker
Copy link
Owner Author

From @toretto460 on November 3, 2016 23:49

I need also this feature to ignore some folders because i don't have read permissions.
Ex. I have a .mysql folder used to mount a docker volume and I receive the following error

[Error - 7:59:42 PM] Server initialization failed.
  Message: RecursiveDirectoryIterator::__construct(/project/.mysql/my_db_name): failed to open dir: Permission denied
  Code: -32603 

@felixfbecker
Copy link
Owner Author

From @simonrozsival on November 4, 2016 11:11

+1

@felixfbecker
Copy link
Owner Author

From @d0x2f on November 14, 2016 2:10

When using Composer, PHP-Intellisense simply fills my error box with hundreds of errors and warnings from third party dependencies in the vendor directory.

I think it shouldn't show errors from directories within the files.exclude vscode setting. That setting seems to align with this issue.

@kaloyan-raev
Copy link
Contributor

kaloyan-raev commented Nov 14, 2016

In Eclipse PDT we have the concept of "library folders". These a folders that are indexed, but no validation and static code analysis is done for them. Composer's "vendor" folder is automatically set as a library folder. Users can mark and unmark library folders as they wish.

@Seldaek
Copy link

Seldaek commented Nov 14, 2016

I agree that defaulting to vendor/ is ok, but it should be configurable as some people change the vendor dir to be something else (composer.json > config > vendor-dir lets you do that), and other projects have libraries in more places than one.

@felixfbecker
Copy link
Owner Author

Sure, but currently there is no configuration at all for the LS so didChangeConfiguration etc. would have to be implemented first.

@ianef
Copy link

ianef commented Feb 22, 2017

+1 for this.
It's intensely annoying every time I open a Symfony project I get recursive directory crashes from the LS..

@felixfbecker
Copy link
Owner Author

@ianfoulds This issue is already implemented and closed. If you experience crashes, please open a new issue.

Repository owner locked and limited conversation to collaborators Feb 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants