Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(completion): don't suggest <?php on > characer #527

Merged
merged 2 commits into from Nov 16, 2017
Merged

fix(completion): don't suggest <?php on > characer #527

merged 2 commits into from Nov 16, 2017

Conversation

felixfbecker
Copy link
Owner

closes #372

@jens1o
Copy link
Contributor

jens1o commented Nov 15, 2017

Awesome! :)

@codecov
Copy link

codecov bot commented Nov 15, 2017 •
edited by ghost

Codecov Report

Merging #527 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #527      +/-   ##
============================================
+ Coverage     79.13%   79.25%   +0.11%     
- Complexity      810      814       +4     
============================================
  Files            55       56       +1     
  Lines          1927     1938      +11     
============================================
+ Hits           1525     1536      +11     
  Misses          402      402
Impacted Files Coverage Δ Complexity Δ
src/Protocol/CompletionContext.php 100% <100%> (ø) 1 <1> (?)
src/CompletionProvider.php 94.4% <100%> (+0.25%) 102 <69> (+3) ⬆️
src/Server/TextDocument.php 75% <100%> (ø) 55 <1> (ø) ⬇️

This was referenced Nov 15, 2017
Closed
Closed
Closed
Closed
@felixfbecker felixfbecker merged commit b1a1875 into master Nov 16, 2017
@felixfbecker felixfbecker deleted the no-html-completion branch November 16, 2017 06:38
@kevinfiol
Copy link

This is still happening on my end. I have the latest version. Even tried uninstalling and reinstalling the extension.

Here are my extensions:
iruiwgfhybjh_code_2017-12-13_16-37-40

Here's a .gif:
vqfgnxx4wwco_2017-12-13_16-39-01

Anyone have any ideas? On Windows 7, btw.

@felixfbecker
Copy link
Owner Author

It's probably not released in VS Code yet.

cgxxv pushed a commit to cgxxv/php-language-server that referenced this pull request Mar 25, 2022
@felixfbecker
fix(completion): don't suggest <?php on > characer (felixfbecker#527)
edc6994 
closes felixfbecker#372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntelliSense always suggests "<?php" when in HTML
3 participants
@felixfbecker @jens1o @kevinfiol