Support rootUri #672
Merged
Support rootUri #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
requested changes
Sep 9, 2018
Codecov Report
@@ Coverage Diff @@
## master #672 +/- ##
============================================
- Coverage 82.16% 82.14% -0.03%
- Complexity 921 933 +12
============================================
Files 44 44
Lines 2148 2151 +3
============================================
+ Hits 1765 1767 +2
- Misses 383 384 +1
|
felixfbecker
reviewed
Sep 9, 2018
src/LanguageServer.php
Outdated
| { | ||
| if ($rootPath === null) { | ||
| $rootPath = \LanguageServer\uriToPath($rootUri); |
There was a problem hiding this comment.
You are in the LanguageServer namespace, so you shouldn't need to use a fully qualified function name. Just call uriToPath()
JJK96
force-pushed
the
master
branch
2 times, most recently
from
5381b20
to
4535d0f
Compare
felixfbecker
approved these changes
Nov 11, 2018
|
🎉 This PR is included in version 5.4.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request depends on felixfbecker/php-advanced-json-rpc#27 to ensure that the arguments do not shift.