Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding p as timezone offset, e.g. +02:00 #56

Closed
wants to merge 4 commits into from
Closed

Adding p as timezone offset, e.g. +02:00 #56

wants to merge 4 commits into from

Conversation

fboes
Copy link
Contributor

@fboes fboes commented Aug 5, 2016

Because the feed validator for ATOM complains about timezone offset being given as +0200 and not as +02:00, I added a slight modification of the o and called it p (like in PHP's date function).

Cheers & thanks for this great lib,
Frank

closes: #148

@axelson
Copy link

axelson commented Dec 30, 2016

Looking forward to being able to use this directly! Is there a workaround to use until this lands?

@fboes
Copy link
Contributor Author

fboes commented Dec 30, 2016

Something like this:

dateFormat(date, 'isoDateTime').replace(/(\d{2})(\d{2})$/, '$1:$2');

@loheander
Copy link

As an interrim solution, fixed in https://www.npmjs.com/package/dateformat-light/v/1.3.0

@fboes
Copy link
Contributor Author

fboes commented Apr 24, 2019

As the original solution is more than 2 years old, I changed it to be mergable to the current official state.

@chase-manning
Copy link
Collaborator

@fboes Thanks so much for creating this PR!!! This is such a good idea 😄
Sorry this was not merged earlier, this repo was not under active maintenance at the time.
I would love to merge this now but there are currently some merge conflicts.
Would you be able to please fix these merge conflicts and then I will happily merge this!

@fboes
Copy link
Contributor Author

fboes commented Dec 5, 2020

Because the merge conflicts were to complicated, I build a completely new solution in #149. Please disregard this pull request. ;)

@fboes fboes closed this Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create p Mask
4 participants