Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect work with double-quoted substrings. #68

Merged
merged 1 commit into from Feb 8, 2018

Conversation

anikolaev
Copy link
Contributor

Their content was not ignored. Original function works correctly.

// correct
dateFormat('2017-06-16', "'yyyy'") // yyyy

// wrong
dateFormat('2017-06-16', '"yyyy"') // "2017"

@MrAlexand0r
Copy link

Ah, that's why it didnt work! Thank you :) 👍

@Sidaroth
Copy link

Sidaroth commented Feb 7, 2018

We just ran into this issue in our project using a custom mask as well, it would be great if this could be accepted as it solves the problem. @felixge

@felixge felixge merged commit d3e929d into felixge:master Feb 8, 2018
@felixge
Copy link
Owner

felixge commented Feb 8, 2018

I'm not maintaining this project anymore and have notifications turned off by default. If one of you wants to help in the future, and e.g. cut a npm release for this, please let me know your GH+NPM usernames so I can give you access.

@doowb
Copy link
Collaborator

doowb commented Feb 8, 2018

@felixge I'm happy to help. I'm doowb on both GitHub and NPM.

@felixge
Copy link
Owner

felixge commented Feb 9, 2018

@doowb I added you on GH/NPM. Feel free to cut a new release for this change. Thanks a ton :)

@doowb
Copy link
Collaborator

doowb commented Feb 9, 2018

Thanks! Published as 3.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants