Fix: Handle resume errors

node-formidable · Jun 16, 2010 · c9df5fe · c9df5fe
1 parent af57e61
commit c9df5fe
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/formidable/incoming_form.js b/lib/formidable/incoming_form.js
@@ -36,7 +36,13 @@ IncomingForm.prototype.parse = function(req, cb) {
   };
 
   this.resume = function() {
-    req.resume();
+    try {
+      req.resume();
+    } catch (err) {
+      this._error(err);
+      return false;
+    }
+
     return true;
   };
 

diff --git a/test/simple/test-incoming-form.js b/test/simple/test-incoming-form.js
@@ -63,6 +63,19 @@ test(function parse() {
     gently.expect(REQ, 'resume');
     assert.strictEqual(form.resume(), true);
   })();
+
+  (function testResumeException() {
+    var ERR = new Error('dasdsa');
+    gently.expect(REQ, 'resume', function() {
+      throw ERR;
+    });
+
+    gently.expect(form, '_error', function(err) {
+      assert.strictEqual(err, ERR);
+    });
+
+    assert.strictEqual(form.resume(), false);
+  })();
 
   (function testEmitError() {
     var ERR = new Error('something bad happened');