Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option: always light theme by default #50

Closed
punkyard opened this issue Mar 5, 2024 · 2 comments
Closed

New option: always light theme by default #50

punkyard opened this issue Mar 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@punkyard
Copy link

punkyard commented Mar 5, 2024

hi
when dark theme is installed, we have a nice switch in the middle of the menu top, which allows people to choose which mode they prefer. But also once the module is installed, by default, the home page is shown in the dark mode.

it would be nice to be able to set this switch to a default position in order to keep the home page bright AND offer the possibility to switch to dark.

Finally, using the switch on home page for a user that's not logged in, drives to loggin page. Which is not the result we expected.

Thanks a lot for your concern and if can make it evolve ✌️

@felixhahnweilheim felixhahnweilheim added the enhancement New feature or request label Mar 5, 2024
@felixhahnweilheim
Copy link
Owner

Dear @punkyard thanks for reporting the bug when logged out. I have created a seperate issue and will look into it.

By default the system setting is selected. So only if your browser/device is in dark mode you will have it dark.
This is the expected behaviour for me.
Of course I would be open to a pull request that introduces a new configuration option.

@felixhahnweilheim felixhahnweilheim changed the title default theme New option: always light theme by default Mar 5, 2024
@punkyard
Copy link
Author

punkyard commented Mar 5, 2024

Thanks for your concern @felixhahnweilheim

@punkyard punkyard closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants