Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete filter edges #424

Closed
MythosOnGit opened this issue May 13, 2022 · 4 comments
Closed

Can't delete filter edges #424

MythosOnGit opened this issue May 13, 2022 · 4 comments

Comments

@MythosOnGit
Copy link

Hello. I'm a big fan of TiddlyMap. However, I've recently discovered an issue. Edges of type tw-filter cannot be deleted in the graph.

Reproduction

  1. Create an edge between two nodes of type tw-filter, either by drawing it, or adding a field to one of the nodes.
  2. Click on that edge in the graph.
  3. Click "Delete Selected"
  4. It says "edge deleted", but nothing happens.

Thank you.

@flibbles
Copy link
Collaborator

This was deliberately not implemented. tw-filter edge types don't really lend themselves to having their edges deleted through the GUI. The problem is that edges created by filters might be done by something like [tag[myTag]] or something even more complex. Removing them might not be something programmatic, so it's treated more like the tw-body edge types where links aren't able to be removed.

@MythosOnGit
Copy link
Author

Are you sure there's nothing that can be done? I have a plugin which introduces several tw-filter types, and this is so far the biggest complaint I'm getting.

Several of my users are only using only the "Add Edge" button to populate edges. Seems like in those cases, "Delete Selected" should be able to work as intended since the filter won't be any different from a title list. If it's any more complicated than that, then skip. That would cover most use cases for me.

@flibbles
Copy link
Collaborator

I'll do you one better. I stole some code from my Uglify project and implemented this in a way that I think should handle 99% of all cases. There are combinations of having complex filters and using the graph buttons which might result in some odd filters, but they should still behave as expected.

I've pushed a release, but I can't update the demo site, so you'll have to check it out of the repository.

@MythosOnGit
Copy link
Author

Thank you! Just tested it and it works great. I appreciate your going to the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants