Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outsourcing the decision where to open a tiddler to the core #7

Closed
felixhayashi opened this issue Apr 21, 2015 · 2 comments
Closed
Labels

Comments

@felixhayashi
Copy link
Owner

Once Jermolene/TiddlyWiki5#1662 is merged, the "top story plugin" shall only be responsible for making tiddlers scroll till they their title is visible at the top of the window. It shall not do any rearrangement anymore.

@danielo515
Copy link

So you are thinking in a new plugin? What kind of rearrangement was planned?

@felixhayashi
Copy link
Owner Author

Hi @danielo515,

So you are thinking in a new plugin?

no not really. I just want to remove the rearrangement that is currently done by the plugin to the core (see demo of Jermolene/TiddlyWiki5#1662). At the moment, the plugin will open links at top by rearranging the dom positions (because tw adds a tiddler below the current tiddler naturally and I then rearrange afterwards). Then it scrolls till the tiddler reaches the top of the window.

IMO the top story view plugin should only focus on scrolling properly (so the title of a tiddler appears at top after navigation) and it is the job of tiddlywiki to let the user decide where a link should open (below/above/top/bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants