Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set fixed filterbar height #26

Closed
tobibeer opened this issue Jan 12, 2015 · 4 comments
Closed

don't set fixed filterbar height #26

tobibeer opened this issue Jan 12, 2015 · 4 comments

Comments

@tobibeer
Copy link

Use min-height instead...

minh

minhfixed

Perhaps also give those in-graph buttons the background color of the graph?

felixhayashi added a commit that referenced this issue Jan 12, 2015
@felixhayashi
Copy link
Owner

good point. now editor cannot shrink less than 350px.

Perhaps also give those in-graph buttons the background color of the graph?

I cannot style the buttons because it's png (not svg) and provided by vis...

@tobibeer
Copy link
Author

Not sure what you mean, but you can sure give...

.network-manipulationDiv

...a background other than transparent, if you wanted to.

Or those .network-manipulationUI / .network-manipulationLabel things.

@felixhayashi
Copy link
Owner

Ok, this was a misunderstanding I thought by graph buttons you mean the navigation buttons. But you are talking about the manipulation buttons in the graph's manipulation bar.

Yes, I think I should add a background color. Otherwise it's hard to read.

@tobibeer
Copy link
Author

Also, not sure how much effort is involved, it would be helpful if all tiddlymap classed had a common class prefix assigned to them, e.g. t-map or some such, e.g.

  • t-map-graph
  • t-map-graph-btn
  • t-map-filterbar
  • t-map-filterbar-btn
  • t-map-tiddler-btn
  • t-map-popup-foo
  • etc...

...but don't sweat about it

felixhayashi added a commit that referenced this issue Jan 14, 2015
fixed #26 by changing the manipulation bar background
and adding a minheight for everything displayed in the sidebar

fixing #12 by allowing to override vis option tiddler

bugfixes and other stuff (better exception handling etc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants