-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login Redirect #8
Comments
Hey @fmatuszewski, this is currently just a solution for handling api rests and so on. What's in my mind:
Just let me know if you'll push a PR, thanks! |
Closed because of inactivity. |
Hi @felixheck , thanks for this awesome plugin. I was making my way from keycloak-hapi, via your JIRA-Ticket in Keycloak to this repo :) I am also interested in the authentication flow, since I use hapi also for ui routes. I think it would make sense to stick close to the configuration of the keycloak-connect middleware, where this is called |
Hi @phal0r — thanks for your feedback, happy to hear that :) I would like to discuss the details first. By personal preference would be:
|
https://github.com/felixheck/hapi-auth-keycloak/tree/redirect Feel free to use the release candidate. Please provide feedback as soon as you've tried it. |
@felixheck
For redirecting to the keyloak login, the plugin should also automatically create callback-urls and handle the return values after a successful login. At this point the plugin will retrieve auth tokens and probably refresh tokens and they need to be stored somewhere. I open for debate on how this should be handled. Should the plugin just set a cookie with the token and handle everything related to it or do we need an extension point for more advanced integration regarding sessions. There will be a lot of scenarios, where business logic wants to access the token to get user information or other custom information. I don't know, if there will be more requirements, but for now this would be a good starting point. I will definitely check your branch and provide feedback as soon as I engage authentication, but this might take some time. So please don't expect an answer on next monday :) But thanks a lot of for this fast implementation, I appreciate it very much. |
Feel free to contribute. |
Closed because of inactivity. Reopened on demand. |
Yeah, ok. It is still on our agenda, but there is still some conceptual stuff to do. |
If you wanna chat in a user-friendlier environment drop a line. We can discuss this stuff in Slack or the like. Really open for this feature but I don't have enough specification to implement it as a whole :) |
How to make actual redirection to keycloak login window.
I thouth it will be done if request is not authorized.
But I just get 401 Unauthorized.
The text was updated successfully, but these errors were encountered: