Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing of Queue isn't handled #84

Closed
Imbuedhush opened this issue Mar 9, 2020 · 4 comments
Closed

Closing of Queue isn't handled #84

Imbuedhush opened this issue Mar 9, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@Imbuedhush
Copy link

Hello
If you will try to setQueue(bullInstance) to the board and then bullInstance.close() => it will produce error "Error: Connection is closed.", please make it just removing it from dashboard

@Imbuedhush
Copy link
Author

Imbuedhush commented Mar 9, 2020

here is completed code for removing of queue from dashboard, that can be used before closing of queue

Not sure i can ask a pull request

  removeQueues: (bullQueues) => {
    if (!Array.isArray(bullQueues)) {
      bullQueues = [bullQueues];
    }

    bullQueues.forEach((item) => {
      delete queues[item.name]
    })

    return queues
  },

@vcapretz
Copy link
Contributor

hey @Imbuedhush 👋

thanks for opening the issue with the code suggestion! I think this is a valid API for us to add, so if you want to please feel free to open a PR 😄

cc @erikengervall let me know if you have any concerns regarding this

@vcapretz vcapretz added the enhancement New feature or request label Mar 13, 2020
@vcapretz
Copy link
Contributor

hey, @Imbuedhush 👋

we have PR #88 now that introduces a method to replace the queues, so you would send only the ones you want to keep in the dashboard, would that suffice the needs for you? if so I'll go ahead and close this issue as soon as that PR is merged 😄

thanks!

@Imbuedhush
Copy link
Author

yes, it's fine
thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants