Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#8 citation annotation #14

Merged
merged 9 commits into from
Mar 21, 2018
Merged

Conversation

felixreimann
Copy link
Collaborator

fixes issue #8

@coveralls
Copy link

coveralls commented Mar 15, 2018

Coverage Status

Coverage increased (+0.2%) to 17.106% when pulling b00474d on feature/#8-citation-annotation into dfbd014 on master.

Copy link
Member

@michaelhglass michaelhglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we stick to one convention for author names: Either J. Doe or Jane Doe. It's a mixture currently.

*
* <pre>
* &#64;Citation(title = "Opt4J: A Modular Framework for Meta-heuristic Optimization",
* authors = "Martin Lukasiewycz, Michael Glass, Felix Reimann, and J�rgen Teich",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ss -> ß
;)

*
* @author lukasiewycz
*
*/
@Info("DTLZ Problem Suite. (n = m + k - 1)")
@Citation(title = "Scalable multi-objective optimization test problems", authors = "Kalyanmoy Deb, Lothar Thiele, Marco Laumanns, and Eckart Zitzler", journal = "Proceedings of the 2002 Congress on Evolutionary Computation", volume = 1, month = MAY, year = 2002, doi = "10.1109/CEC.2002.1007032")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check given names

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did and found no problem. What is wrong?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See overall comment: I suggest to stick to one naming convention. It seems the majority preferred J. Doe over Jane Doe so I marked all occurrences of the latter.

* Module for the DTLZ benchmarks as proposed in "Scalable multi-objective
* optimization test problems, Kalyanmoy Deb,Lothar Thiele, Marco Laumanns,
* Eckart Zitzler, Proc. Congress Evolutionary Computation Volume 1 (May 2002)".
* Module for the DTLZ benchmarks as proposed in "Scalable multi-objective optimization test problems, Kalyanmoy Deb,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check given names.

* Module for the WFG (Walking Fish Group) benchmarks, see "A Scalable
* Multi-objective Test Problem Toolkit, Simon Huband, Luigi Barone, R. Lyndon
* While, and Philip Hingston (EMO 2005)".
* Module for the WFG (Walking Fish Group) benchmarks, see "A Scalable Multi-objective Test Problem Toolkit, Simon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check given names.

*
* @author lukasiewycz
*
*/
@Info("WFG Problem Suite. The number of search variables is n=k+l.")
@Citation(title = "A Scalable Multi-objective Test Problem Toolkit", authors = "Simon Huband, Luigi Barone, R. Lyndon While, and Philip Hingston", journal = "Evolutionary Multi-Criterion Optimization", pageFirst = 280, pageLast = 295, year = 2005, month = PublicationMonth.UNKNOWN, doi = "10.1007/978-3-540-31880-4_20")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check given names.

* Multiobjective Evolutionary Algorithms: Empirical Results, Eckart Zitzler,
* Kalyanmoy Deb, Lothar Thiele, Evolutionary Computation Volume 8 , Issue 2
* (June 2000)".
* The {@link ZDTModule} configures the ZDT benchmarks, see "Comparison of Multiobjective Evolutionary Algorithms:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check given names.

*
* @author lukasiewycz
*
*/
@Info("ZDT Problem Suite.")
@Citation(title = "Comparison of Multiobjective Evolutionary Algorithms: Empirical Results", authors = "Eckart Zitzler, Kalyanmoy Deb, Lothar Thiele", journal = "Evolutionary Computation Volume", volume = 8, number = 2, month = PublicationMonth.JUNE, year = 2000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check given names.

@@ -33,6 +30,7 @@
*
*/
@Info("The Strength Pareto Evolutionary Algorithm (SPEA II).")
@Citation(title = "SPEA2: Improving the Strength Pareto Evolutionary Algorithm For Multiobjective Optimization", authors = "Eckart Zitzler, Marco Laumanns, and Lothar Thiele", journal = "Evolutionary Methods for Design, Optimisation, and Control", pageFirst = 19, pageLast = 26, year = 2002, month = UNKNOWN)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check given names.

@felixreimann
Copy link
Collaborator Author

All names are now in the form "givenName surname, givenName surname, and givenName surname".

@michaelhglass michaelhglass merged commit e472c45 into master Mar 21, 2018
@felixreimann felixreimann deleted the feature/#8-citation-annotation branch March 21, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants