Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make INSTALLLEVEL and REBOOT properties configurable #116

Merged

Conversation

HKrausAxon
Copy link
Contributor

As with other properties in the wix template, it can
be useful for users of this library to override both
the reboot behavior (e.g. in cases they want to allow
reboots), as well as the install level (e.g. if they
want to exclude install level 2 features or include
install level 3 features without customers having to
use ADDLOCAL or other manual mechanisms).

This change makes both of those properties configurable,
defaulting them to their existing behavior.

It also cleans up a leftover comment (there were two sets
of descriptions for INSTALLPATH; this change removes the
older, misplaced version.

Screenshots

msi created after this change, without setting any custom configs:
NoOverrides
--> We can see INSTALLLEVEL is set to 2, and REBOOT is set to "ReallySuppress"

In this attempt, I added the following two lines to my MSICreator config:

	rebootMode: 'Suppress',
	installLevel: 3,

Which resulted in the following msi properties:
WithOverrides
--> We can see, as expected INSTALLLEVEL is set to 3 and REBOOT is set to "Suppress"
I also validated that Update.exe gets installed and folder permissions are set as per expectation when INSTALLLEVEL is set to "3" (in accordance with the "Auto Update" feature)

As with other properties in the wix template, it can
be useful for users of this library to override both
the reboot behavior (e.g. in cases they want to allow
reboots), as well as the install level (e.g. if they
want to exclude install level 2 features or include
install level 3 features without customers having to
use ADDLOCAL or other manual mechanisms).

This change makes both of those properties configurable,
defaulting them to their existing behavior.

It also cleans up a leftover comment (there were two sets
of descriptions for INSTALLPATH; this change removes the
older, misplaced version.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c626aa1 on HKrausAxon:add_configurability into 4bfb056 on felixrieseberg:master.

@HKrausAxon
Copy link
Contributor Author

Note: The failing tests are unrelated to this PR and had been failing beforehand.
I have created a separate PR to fix those existing issues: #117

@felixrieseberg
Copy link
Collaborator

This looks like a good addition, thank you! I'll merge the PR and release a new minor version.

@felixrieseberg felixrieseberg merged commit 748ae8f into electron-userland:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants