Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create TimeFrame from Period (DatePeriod, TimePeriod) #8

Closed
femtotrader opened this issue Nov 10, 2016 · 2 comments
Closed

Create TimeFrame from Period (DatePeriod, TimePeriod) #8

femtotrader opened this issue Nov 10, 2016 · 2 comments

Comments

@femtotrader
Copy link
Owner

It should be possible to do:

tf = TimeFrame(Dates.Minute(15))
@femtotrader femtotrader changed the title Create TimeFrame from DatePeriod Create TimeFrame from Period (DatePeriod, TimePeriod) Nov 10, 2016
@femtotrader
Copy link
Owner Author

see femtotrader/TimeSeriesResampler.jl#6

@femtotrader femtotrader mentioned this issue Nov 10, 2016
Closed
femtotrader referenced this issue Nov 10, 2016
@femtotrader
TimeFrame can be build using a Dates.Period (TimePeriod or DatePeriod)
30e4897
@femtotrader femtotrader reopened this Nov 11, 2016
@femtotrader
Copy link
Owner Author

Reopen because are doing

function TimeFrame(td::Dates.Period; boundary=Begin::Boundary)
    CustomTimeFrame(dt-> _d_f_boundary[boundary](dt, td))
end

but

tf = TimeFrame(Dates.Minute(15))

shouldn't be a CustomTimeFrame but a TimePeriodFrame

femtotrader referenced this issue Nov 11, 2016
@femtotrader
TimePeriodFrame using Period
20e6e4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@femtotrader