Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using flow or typescript vs prop types #22

Open
phuongy opened this issue Sep 29, 2018 · 2 comments
Open

Using flow or typescript vs prop types #22

phuongy opened this issue Sep 29, 2018 · 2 comments

Comments

@phuongy
Copy link
Member

phuongy commented Sep 29, 2018

Any preferences or arguments about this? Prop types are old and terrible. I think going forward we should go to flow or ts. My TS is rusty so someone else might need to start this change, otherwise we people want to use flowtype, happy to start this branch.

@antonjb
Copy link
Contributor

antonjb commented Sep 29, 2018

I'd lean toward TS simply because I have used that one. I can't say I have had huge issues around typing in a project this size, so I don't have strong feelings either way.

@phuongy
Copy link
Member Author

phuongy commented Oct 3, 2018

Agreed the project is small enough to not warrant the extra effort. Did anyone want to give this a try, could be a good exercise for anyone wanting to mess with TS / flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants