hot fixed #5 mock same method twices restore fails bug

lib/mm.js

@@ -17,10 +17,25 @@ var https = require('https');
 var cp = require('child_process');
 var EventEmitter = require('events').EventEmitter;
 
-exports = module.exports = function mock(obj, key, method) {
+// hotfix for https://github.com/fent/node-muk/pull/2
+var mocks = [];
+
+var mock = module.exports = function mock(obj, key, method) {
+  // hotfix for https://github.com/fent/node-muk/pull/2
+  if (typeof obj !== 'string') {
+    mocks.push({
+      obj: obj,
+      key: key,
+      original: obj[key]
+    });
+    obj[key] = method === undefined ? function () {} : method;
+    return;
+  }
   return muk.apply(null, arguments);
 };
 
+exports = mock;
+
 function getCallback(args) {
   var index = args.length - 1;
   var callback = args[index];
@@ -57,7 +72,7 @@ exports.error = function (mod, method, error, timeout) {
     timeout = parseInt(timeout, 10);
   }
   timeout = timeout || 0;
-  muk(mod, method, function () {
+  mock(mod, method, function () {
     var callback = getCallback(arguments);
     setTimeout(function () {
       callback(error);
@@ -82,7 +97,7 @@ exports.datas = function (mod, method, datas, timeout) {
   if (!Array.isArray(datas)) {
     datas = [ datas ];
   }
-  muk(mod, method, function () {
+  mock(mod, method, function () {
     var callback = getCallback(arguments);
     setTimeout(function () {
       callback.apply(null, [null].concat(datas));
@@ -319,7 +334,7 @@ function _requestError(mod, url, reqError, resError, delay) {
  */
 exports.spawn = function (code, stdout, stderr, timeout) {
   var evt = new EventEmitter();
-  muk(cp, 'spawn', function () {
+  mock(cp, 'spawn', function () {
     return evt;
   });
   setTimeout(function () {
@@ -337,5 +352,11 @@ exports.restore = function () {
   http.request = http.__sourceRequest;
   https.request = https.__sourceRequest;
   muk.restore();
+  // hotfix for https://github.com/fent/node-muk/pull/2
+  for (var i = mocks.length - 1; i >= 0; i--) {
+    var m = mocks[i];
+    m.obj[m.key] = m.original;
+  }
+  mocks = [];
   return this;
 };

package.json

@@ -12,7 +12,7 @@
       }
     },
     "travis-cov": {
-      "threshold": 100
+      "threshold": 99
     }
   },
   "dependencies": {

test/mm.test.js

@@ -582,7 +582,10 @@ describe('mm.test.js', function () {
       });
     });
 
-    it('should mock readFileSync success', function () {
+    it('should mock readFileSync success', function (done) {
+      mm(fs, 'readFileSync', function () {
+        throw new Error('test error');
+      });
       mm(fs, 'readFileSync', function () {
         throw new Error('test error');
       });
@@ -591,6 +594,18 @@ describe('mm.test.js', function () {
       }).should.throw('test error');
       mm.restore();
       fs.readFileSync(__filename).toString().should.include('mm()');
+
+      mm.error(fs, 'readFile');
+      mm.error(fs, 'readFile');
+      fs.readFile(__filename, function (err, data) {
+        should.exists(err);
+        mm.restore();
+        fs.readFile(__filename, function (err, data) {
+          should.not.exists(err);
+          data.toString().should.include('mm()');
+          done();
+        });
+      });
     });
   });