-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isShown
to TypeScript annotations
#610
Comments
The |
Can you give a good reason for why you can't give us a getter like
|
|
There are too many internal properties (about 30). I don't think it is a good idea to expose any one of them as they may be changed later. |
Is your feature request related to a problem? Please describe.
I use the
isShown
attribute of my viewer to disable my programs hotkeys while the viewer is open:But typescript thinks
isShown
isn't a value on viewer, despite it being one.Describe the solution you'd like
When it comes to variables that could be useful to people, like
isShown
add them to TypeScript annotationsDescribe alternatives you've considered
If you don't want people writing to them, mark them private and add getters so we can still use them in a readonly manner (ie:
getIsShown()
)The text was updated successfully, but these errors were encountered: