Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat qrcode as dependency rather than peerDependency #44

Closed
colgin opened this issue Nov 29, 2021 · 2 comments
Closed

Treat qrcode as dependency rather than peerDependency #44

colgin opened this issue Nov 29, 2021 · 2 comments

Comments

@colgin
Copy link

colgin commented Nov 29, 2021

In version 1.x, qrcode is dependency, but it changed now, it is peerDependency now. I'm really puzzled about what makes this change.
In my opinion, users don't need to install qrcode manually if qrcode is treated as dependency.

@fengyuanchen
Copy link
Owner

For a peer dependency, users can choose the exact version of qrcode as they need, just like Vue components don't list vue package as a dependency but as a peer dependency.

@housemeow
Copy link

how about use overrides and resolutions properties to replace peer dependency?

https://stackoverflow.com/a/64452515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants