Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect URLs Cause Crashes #57

Closed
fennifith opened this issue Sep 28, 2018 · 0 comments
Closed

Incorrect URLs Cause Crashes #57

fennifith opened this issue Sep 28, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@fennifith
Copy link
Owner

The GitHub API appears not to verify that URLs input into the 'blog' field are actually URLs, so if a url that doesn't start with either http:// or http:// is provided then Attribouter crashes whenever one is clicked (since it just throws the value directly into the ACTION_VIEW data without checking that it's valid). Ideally, it should be validated before the link is even created so that even if the URL is invalid for some other reason, it still doesn't cause an error.

@fennifith fennifith added the bug Something isn't working label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant