Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer error messages, fallback behavior when auth token is invalid #65

Closed
fennifith opened this issue Apr 22, 2019 · 0 comments
Closed
Labels
bug Something isn't working
Projects

Comments

@fennifith
Copy link
Owner

I didn't realize this when making the project, but the GitHub API will return a 400 error if it is passed an invalid auth token. This causes all requests sent by the library to fail, and any data needed from GitHub will not be fetched.

Ideally, the library should simply resend the request without the auth token in this situation, and should warn the developer that it is invalid. This will make troubleshooting a lot easier, rather than failing to identify the problem and blaming it on something else (prime example: #64).

I should probably also put something in the README about not committing auth tokens to version control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Roadmap
  
Done
Development

No branches or pull requests

1 participant