Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

handle new warning style #46

Merged
merged 3 commits into from Oct 24, 2014
Merged

handle new warning style #46

merged 3 commits into from Oct 24, 2014

Conversation

przemyslawpluta
Copy link
Owner

fix if no cc are available - download anyway without cc

fix if no cc are available - download anyway without cc
updated new formats to pass test
@fent
Copy link
Collaborator

fent commented Oct 23, 2014

Is there a video I can try this on? the one I tried on gives me the old string with the latest version of youtube-dl

@przemyslawpluta
Copy link
Owner Author

Travis testes failed on the original video with the previous formats and I've tested this on the original video from the test http://www.youtube.com/watch?v=0k2Zzkw_-0I getFormat.js#L4 and it passes with new formats.

Tested and fails with old formats agains py youtube-dl 2014.10.23 passes with new formats.

fix when no subs with correct args filter
@fent
Copy link
Collaborator

fent commented Oct 24, 2014

Thank you!

Hmm, maybe I should come up with a better way to test for getFormats() since it keeps changing for that video.

fent added a commit that referenced this pull request Oct 24, 2014
@fent fent merged commit ee04e43 into przemyslawpluta:master Oct 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants