fix: throw more helpful error when downloading format from `getBasi…

…cInfo()` closes #704
fent · Sep 25, 2020 · 0ecb0c4 · 0ecb0c4
1 parent a9c4574
commit 0ecb0c4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -83,6 +83,9 @@ exports.sortFormats = (a, b) => {
  */
 exports.chooseFormat = (formats, options) => {
   if (typeof options.format === 'object') {
+    if (!options.format.url) {
+      throw Error('Invalid format given, did you use `ytdl.getInfo()`?');
+    }
     return options.format;
   }
 

diff --git a/test/util-test.js b/test/util-test.js
@@ -241,6 +241,14 @@ describe('util.chooseFormat', () => {
       const format = util.chooseFormat(sortedFormats, { format: formats[0] });
       assert.strictEqual(format, formats[0]);
     });
+
+    describe('from `getBasicInfo()`', () => {
+      it('Throws error', () => {
+        assert.throws(() => {
+          util.chooseFormat(sortedFormats, { format: formats.filter(format => !format.url)[0] });
+        }, /Invalid format given/);
+      });
+    });
   });
 
   describe('With filter given', () => {