Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading way slower than usual #1240

Closed
erturkdotgg opened this issue Jul 12, 2023 · 15 comments
Closed

Downloading way slower than usual #1240

erturkdotgg opened this issue Jul 12, 2023 · 15 comments

Comments

@erturkdotgg
Copy link

erturkdotgg commented Jul 12, 2023

Ytdl core is working so slow since last 2 days. Its downloading files very very slow.

Many people are also experiencing same issue at the ytdl-core discord server. Need a fix right now.

@endblack
Copy link

Também estou com o mesmo problema

@nextpier
Copy link

Same for me...

@yyildiz
Copy link

yyildiz commented Jul 12, 2023

We've been experiencing this issue for the past two days now.

@gathilas
Copy link

This is happening to me too. Slow is kind of an understatement, it can take hours to download a video and a lot of times it'll just stop downloading all together.

@sacreations
Copy link

same for me

@matthewredmongross
Copy link

same

@chenaaron3
Copy link

Seeing problems with this too. My lambda functions are timing out.

@gatecrasher777
Copy link
Contributor

I've picked up, in another project, that there is in the past 24 hours, a syntax error in extracting the n-transform function. You will always get very slow speeds without the n-transform working properly. Will try to trace the problem today.

@preetam52c
Copy link

ytdl-core downloading video very slowly. We are facing major issue for this. Does anyone fond any solution? It's taking hours to download. Please fix it. 🙏🏼

@gatecrasher777
Copy link
Contributor

gatecrasher777 commented Jul 13, 2023

line 59 in sig.js

  if (functionName.includes('[')) functionName = utils.between(body, `${functionName.split('[')[0]}=[`, `]`);

needs to be

  if (functionName.includes('[')) functionName = utils.between(body, `var ${functionName.split('[')[0]}=[`, `]`);

Because if other functions end in the same character sequence it fails to find the correct function. In this case, the functionName was "ata" and there is a bunch of other functions called "Data"

Created PR #1242

@chenaaron3
Copy link

lgtm, can we publish this to a new version?

@nextpier
Copy link

nextpier commented Jul 13, 2023

@gatecrasher777 thank you. It works fine. Is there a way to incorporate your PR in the package.json of our projects? It seems that this great repo is no longer mantained...

@gatecrasher777
Copy link
Contributor

  "dependencies": {
    "ytdl-core": "github:gatecrasher777/node-ytdl-core#master"
  }

@nextpier
Tested this and it seems to work.
May have to delete package-lock.json and node-modules folder.
Then run npm install.
Then revert back to version number if/when the PR is merged.

@endblack
Copy link

This really worked, thank you very much.

@TimeForANinja
Copy link
Collaborator

Closed with the merge of #1242
let's say poorly maintained and not "no longer mantained" 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests