Change URL format in getInfo #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 594 594
Branches 148 148
=====================================
Hits 594 594
Continue to review full report at Codecov.
|
fent
reviewed
Jan 30, 2018
lib/info.js
Outdated
| @@ -80,8 +80,8 @@ module.exports = function getInfo(link, options, callback) { | |||
| // Get related videos. | |||
| related_videos: util.getRelatedVideos(body), | |||
|
|
|||
| // Give the canonical link to the video. | |||
| video_url: url, | |||
| // Give the raw link to the video. | |||
There was a problem hiding this comment.
Alright
fent
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Update info.js * Raw -> Standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set the URL on the return for info, it includes every parameter in the video. This is fine until you start wanting to compare this video to a saved URL you may have (This is just one use case). Using a standardized format, we should instead just put the raw URL. If requested, we could also put the parameters in a separate variable or even the URL with parameters in a second variable.